add img (logo) and download api #72
Conversation
add `img` prop: { src, left, top, width, height }
add `genCanvas()`, `genCanvasDataURL()` and `download()` to provide
download feature
|
a demo here: https://static.pastleo.me/qrcode.react-example/ |
|
@zpao Hi! Just want to confirm is this PR will be merged? |
useful！ |
|
for people who found here: if you want to install my fork to your project, you can do so by: npm i https://github.com/pastleo/qrcode.react/releases/download/0.9.2.2/qrcode.react.tar.gz
# or
yarn add https://github.com/pastleo/qrcode.react/releases/download/0.9.2.2/qrcode.react.tar.gzusage and demo: https://static.pastleo.me/qrcode.react-example/ |
|
This PR is really useful, will it be merged? @zpao I think given the feedback it received it would be a massive addition |
|
This library is great but is it now unmaintained? |
|
I added support for embedding in #81 (and shipped in v1.0.0). I didn't add support for downloading yet as I don't think I want to do it the way you have here. In particular, I'm not convinced always rendering to canvas is best and I can see an argument for downloading the vector format if rendered as SVG. I'll leave this open to revisit. Thanks for doing this and inspiring me to actually get something supported! |
|
would love if this was merged in (or these features implemented in another way) |
|
This is super cool - @pastleo would you mind opening this pr here - i would love to help getting this feature: https://github.com/devmehq/react-qr-code |
img (logo) issues:
download issues: